Now krellin I understand what you're saying here. Economic prosperity is measured on the amount that a society produces - GDP. Transfer payments (such as social security and Medicare) are not included in GDP. The point of many of these projects wasn't to build things (though it easily could have been changed to different projects that would produce more tangible benefits, I can give you that). The point was to give men a job, keep them busy 8 hours a day, and put money in their pocket.
It was basically a handout in principle, but the way they did it 1) made GDP go up and 2) Made those who now worked on government projects feel better about themselves. I mean back then there wasn't any social security so it was either work or tell your wife you can't provide for her and the kids. I'm not close to becoming married yet, but I don't think any guy wants to say that to his wife.
So this did two things, it improved the morale of the American people, lowered unemployment, and stopped GDP from falling. Consider that from an investing standpoint. You're sitting on a bunch of cash that you have left after the stock market crash and thousands of bank failures. You don't want to invest that money anywhere, because the economy is still shit, unemployment is increasing, and you can't trust anywhere to put it. Now with these programs though, you are getting injections of money into the economy, deflation has stopped, and unemployment is decreasing. A much brighter economic prospect, no? I mean, with deflation (like there was) its better to sit on your money than put it anywhere. Once that ended, banks could start upping interest rates a bit by bit (which had been at practically 0% since 1929) and more importantly, more money meant more money people could put in banks and more money that could be lent out to investors who wanted to build the private sector. I simply don't think the private sector had enough to revive itself. If it did, why didn't it recover from 1930-1932? That's three years.
I do agree though, that Obama hasn't held up to his promises on rebuilding infrastructure. It is mostly his fault, but not 100%. I remember reading an article where they were trying to build a high speed rail in Florida from Miami to somewhere, but they weren't able to buy the land. Again, mostly, but not solely his fault.
And I agree with you in concept of shifting responsibility from federal to state governments. I'm all for that. I also agree that doing it the way it does lets the Bureaucracy skim some money away. BUT, Congress will never do this because they use highway funding as leverage to get states to pass the laws they want, and state legislatures won't do it because they'll be voted out of office for raising taxes to cover it!
Again, politics gets in the way of the better solution