Thank you. Pausing the games is without a doubt the best option.

Take your time, as long as it gets cleaned up.

Can you move it back so that I can return to the past and guess correctly this time what my enemies and allies will do? ;)


Thanks for taking the time and trouble for us mere mortals.

When I run new orders on my home server it seems to all work fine, and when I look back in the access logs to the time when all the messed up games got messed up it looks like someone ran several gamemaster scripts at once.

The locking should prevent this from being a problem, but that has been flaky in the past so I think this was a locking bug, where games were processed by two different scripts at the same time.

At the moment I'm writing some code that'll let the gamemaster reprocess the corrupted games without having to move the entire database back by restoring individual games from the archive tables, and I'm also making it so that only the cron script which runs every 5 minutes will be able to run the gamemaster, so no more locking issues should occur.

it is doog to see that you respond so fast to a problem:)

how will you determine which games are corrupted? Or will you just rerun everything? If you want to skip the one where I got to keep 2 extra armies but re-process the ones where I didn't get my appropriate builds, that would be fine.

Are games going to go backward a season then?

I'm in 3 games right now, one of which the 'bug' has manifested itself... will all 3 go back a season or will only the one go back?

http://www.phpdiplomacy.net/board.php?gameID=4154
Belgium supported Hold Holland.
Russia moved Ruhr to HOlland supported by Kiel.

The French hold should have been enough to keep the SC, but it was not and the unit in Holland was defeated. Can I assume this is part of the same bug?

Looks like there was no support (no green line visible on the map). France did not support

The green support line is clearly visible on the large map. It isn't on the small map because it shows as a broken support, but nothing attacked Belgium and should therefore not have been broken.

The cross (or X) on the green line is on Belgium, not in Holland which means that Holland supported Belgium to hold.

the confusion over orders shown only by the map could be resolved by some simple text output. (i suggest using a javascript to hide the order unless you click to read them, invisible tag...)

ah that makes sense.

its holland support of belgium not the other way around

I reprocessed all games and returned them to the last Diplomacy phase, which should undo any errors without giving anyone an advantage of knowing what others are doing.

Also the reprocessing code will be useful for correcting adjudication errors in the future.

I also discovered that due to recent slowness problems the database was moved to a faster server last night, that might also have had something to do with this problem.

Thanks for moving so fast on this, Kestas.

The game Move Along Now appears to not have been corrected in this process. http://phpdiplomacy.net/board.php?gameID=4490

this is going to cause havoc with people who know their opponent's orders. not that anyone will be doing the same thing, of course.



(disclaimer: that's what they want you to think.)

Is it possible that some games moved back more than one phase? I could have sworn we had already done retreats AND /builds, and now we were on our next set of moves. Now we are back at retreat.
http://phpdiplomacy.net/board.php?gameID=4326

i think so, if your phase passed relatively quickly. actually, no, that wouldn't be necessary; just that it's a fast game and the last two passed within 24 hours (not total - the end of moves being 24 hours from the beginning of builds, with retreats taking <24).

oh, and who here hopes this bug also shows up on playdiplomacy.com? anyone?

If you were in a Diplomacy phase you would have moved back to the previous Diplomacy phase, then gotten reprocessed, I should have said everyone is moved back a whole turn, not one phase.

TheMasterGamer: That is very disconcerting :-( if some games got fixed and others didn't that is very confusing

thank you for the fast resolution.
but, about bugs, i think they make the game interesting, it is like in real wartimes, something happens that nobody anticipated

you mean, like a plague? that would be interesting. let's roll dice to remove random armies.

Looking in one of my games I can see the bug wasn't a one-off thing, it's still happening, and I've set all games to crashed while I resolve this.

I just don't get how it can be working on my server yet not here. It must be the new database which we moved to, but I can't think what difference could be causing this problem

Okay I'm currently accessing the phpdiplomacy.net database from the home dev server code, and when I processed the games using the local code and the .net database the bug appeared, so it looks pretty clear that the database we moved to is what's causing the bug.

Thanks for jumping on this, Kestas, it is appreciated!!

Any/all delays are welcome compared to messed up games, so getting things fixed are a much higher priority than getting things going again quickly... though that's probably a given!

yea, rock on Kestas. take your time