Page 1 of 1

Ghost Rating formula incorrectly listed on /ghostRatings.php

Posted: Mon Jul 24, 2023 5:18 am
by echidna
Hi, I looked at the details of GhostRatings, described on page https://webdiplomacy.net/ghostRatings.php
I believe the formula listed there:
ratingAdjustment = x * (expectedScore - actualScore)
is INCORRECT!
It should read:
ratingAdjustment = x * (actualScore - expectedScore)

I found the piece of code:
$grAdjustment[$userID] = (($grSum / $this->modvalue) * ($actualResult[$userID]-$expectedResult[$userID]));
this clearly shows actual... - expected...

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

Posted: Mon Jul 24, 2023 10:31 am
by Doug7878
The (inquisitive) force is strong with this one. Yes, its clearly stated in reverse.

Can you fix the info page? If not, I guess you would send it to kestas. ( ? )

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

Posted: Mon Jul 24, 2023 11:57 am
by gimix
@Squigs, are you still around?

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

Posted: Mon Jul 24, 2023 12:03 pm
by gimix
(newer members info):
Squigs44 has been a very active and important member of this site, and contributed some nice pieces of code, including the full Ghost Rating system.

We are happy that he reversed Actual and Expected in the explanation, not in the code :lol:

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

Posted: Mon Jul 24, 2023 5:50 pm
by x3n
While I appreciate the work, if Ghost Rating still encourages people to drop out of a game before they lose, and never help out a stalled game by taking up a doomed position, then I think it must still be considered a "work in progress".

Re: Ghost Rating formula incorrectly listed on /ghostRatings.php

Posted: Mon Jul 24, 2023 7:21 pm
by JECE
x3n wrote:
Mon Jul 24, 2023 5:50 pm
While I appreciate the work, if Ghost Rating still encourages people to . . . never help out a stalled game by taking up a doomed position, then I think it must still be considered a "work in progress".
Restore PPSC and restore the practice of betting on joining games in progress. Problem solved without touching the Ghost Rating code!