Control the re-entering the game after CD
-
- Posts: 112
- Joined: Tue Oct 24, 2017 6:16 am
- Location: Chervonohrad, Ukraine
- Karma: 68
- Contact:
Control the re-entering the game after CD
I know that it's already done in webDip sourse code.
Scripts control the player re-entering the game for another power after being kicked out due to CD.
Who can point me the file and the code-line where it is written down?
Scripts control the player re-entering the game for another power after being kicked out due to CD.
Who can point me the file and the code-line where it is written down?
1
-
- Posts: 112
- Joined: Tue Oct 24, 2017 6:16 am
- Location: Chervonohrad, Ukraine
- Karma: 68
- Contact:
Re: Control the re-entering the game after CD
I mean after CD the power is already taken by other player. And I want the code which prevents the old owner of the power to get into the game for another country.
-
- Posts: 112
- Joined: Tue Oct 24, 2017 6:16 am
- Location: Chervonohrad, Ukraine
- Karma: 68
- Contact:
Re: Control the re-entering the game after CD
I didn't find this in webDip sourcecode too.
I think it is considered to be a bug.
I think it is considered to be a bug.
Re: Control the re-entering the game after CD
I’m pretty sure it’s in there. I don’t have time to look right now, but I remember seeing the check in the join game code (have a look for anything that writes to the wd_members table). From memory, the check is not explicit, but implied.
If there’s a bug where you are able to take over another power when you CD, get taken over, and then someone else CDs, I think it would be the easy fix of checking the CD table too.
It would be easy to confirm that the code isn’t there by looking for everything that reads the CD table.
If there’s a bug where you are able to take over another power when you CD, get taken over, and then someone else CDs, I think it would be the easy fix of checking the CD table too.
It would be easy to confirm that the code isn’t there by looking for everything that reads the CD table.
-
- Posts: 112
- Joined: Tue Oct 24, 2017 6:16 am
- Location: Chervonohrad, Ukraine
- Karma: 68
- Contact:
Re: Control the re-entering the game after CD
I see. Thank you for your reply.A_Tin_Can wrote: ↑Tue Dec 29, 2020 5:49 amI’m pretty sure it’s in there. I don’t have time to look right now, but I remember seeing the check in the join game code (have a look for anything that writes to the wd_members table). From memory, the check is not explicit, but implied.
If there’s a bug where you are able to take over another power when you CD, get taken over, and then someone else CDs, I think it would be the easy fix of checking the CD table too.
It would be easy to confirm that the code isn’t there by looking for everything that reads the CD table.
Besides, I'm not sure banned users are out of halloffame.
Anyway I do this fix for Ru-server.
-
- Developer
- Posts: 1098
- Joined: Fri Sep 29, 2017 4:20 pm
- Karma: 2933
- Contact:
Re: Control the re-entering the game after CD
I don't think it's a bug, if you check the comment on line 79 of webDiplomacy\board\member.php from Kestas you'll see this.
Sounds like this was intended functionality on his part.
Code: Select all
/*
* Remove the CD mark from this person's record
* Someone could possible go into CD, be taken over, join another country, go CD again, then rejoin, so country has to be specified
*/
-
- Developer
- Posts: 1098
- Joined: Fri Sep 29, 2017 4:20 pm
- Karma: 2933
- Contact:
Re: Control the re-entering the game after CD
That said, I could swear ATC is right and there is a check that was added later that was implied, but I only skimmed the code for 2 minutes to find this.jmo1121109 wrote: ↑Wed Dec 30, 2020 6:05 amI don't think it's a bug, if you check the comment on line 79 of webDiplomacy\board\member.php from Kestas you'll see this.
Sounds like this was intended functionality on his part.Code: Select all
/* * Remove the CD mark from this person's record * Someone could possible go into CD, be taken over, join another country, go CD again, then rejoin, so country has to be specified */
-
- Posts: 112
- Joined: Tue Oct 24, 2017 6:16 am
- Location: Chervonohrad, Ukraine
- Karma: 68
- Contact:
Re: Control the re-entering the game after CD
Thank you for attention to my request. I will continue the investigation ))
1
-
- Posts: 112
- Joined: Tue Oct 24, 2017 6:16 am
- Location: Chervonohrad, Ukraine
- Karma: 68
- Contact:
Re: Control the re-entering the game after CD
I have finally found this update and installed it. Thanks to everyone.
WebDiplomacy enthusiast. Author or adaptor of webdiplomacy variants: Classic Cataclysm, Classic 1898, Classic 1898 Fog of War, Punic Wars, Western World 901, 13th Century Mongolian Empire, Speed Europa, Minor Power.
Who is online
Users browsing this forum: No registered users and 1 guest