Joined as a replacement, but info shows non-zero bet?

Post a reply

Confirmation code
Enter the code exactly as it appears. All letters are case insensitive.
Smilies
:points: :-D :eyeroll: :neutral: :nmr: :razz: :raging: :-) ;) :( :sick: :o :? 8-) :x :shock: :lol: :cry: :evil: :?: :smirk: :!:
View more smilies

BBCode is ON
[img] is ON
[flash] is OFF
[url] is OFF
Smilies are ON

Topic review
   

If you wish to attach one or more files enter the details below.

Expand view Topic review: Joined as a replacement, but info shows non-zero bet?

Re: Joined as a replacement, but info shows non-zero bet?

by sweetandcool » Sat Apr 01, 2023 3:28 am

Interesting. It still displays that I bet 5, so I guess it's just a display bug.

Re: Joined as a replacement, but info shows non-zero bet?

by kestasjk » Sat Apr 01, 2023 2:11 am

Yep it didn't deduct any points, that ticket is resolved. I even checked the points transaction logs to double check and no points were taken when you joined

Re: Joined as a replacement, but info shows non-zero bet?

by sweetandcool » Sat Apr 01, 2023 12:45 am

Oh did you change it? Just last week I contacted support to get my points back because the game took them when I took over an open position.

Re: Joined as a replacement, but info shows non-zero bet?

by kestasjk » Fri Mar 31, 2023 11:44 pm

Hmm.. I'll have a look into why that might have changed, but in the meantime don't worry when you take over a CD no points are deducted

Re: Joined as a replacement, but info shows non-zero bet?

by jamesa7171 » Fri Mar 31, 2023 9:26 pm

kestasjk wrote:
Fri Mar 31, 2023 2:10 pm
So that bet amount is the amount the membership is worth
The bet amount normally says "Bet: 0" after someone takes over a CD.

(eta: I also encountered this in a game and reported it a while back)

Re: Joined as a replacement, but info shows non-zero bet?

by kestasjk » Fri Mar 31, 2023 2:10 pm

Hmm.. Looking at the code it does look like there is a bet to take over a CD:
https://github.com/kestasjk/webDiplomac ... s.php#L513

Code: Select all

			$bet = $CD->pointsValueInTakeover();
			if ( $User->points < $bet )
				throw new Exception(l_t("You do not have enough points to take over that countryID."));
Oh wait, that value is always 0:

Code: Select all

	/**
	 * CD takeovers cost 0. This is a function because they weren't always free, and keeping the function means we can always change it later.
	 * @return int
	 */
	function pointsValueInTakeover() 
	{
		return 0;
	}	
So that bet amount is the amount the membership is worth, but no points were subtracted from your account to join.

Re: Joined as a replacement, but info shows non-zero bet?

by Rainfromabove » Wed Mar 15, 2023 12:21 pm

Have the same issue actually - also posted a mod report

Re: Joined as a replacement, but info shows non-zero bet?

by echidna » Sun Mar 12, 2023 10:09 pm

JECE, thanks for your guidance, I have submitted to that modforum.

Re: Joined as a replacement, but info shows non-zero bet?

by JECE » Sun Mar 12, 2023 6:57 pm

I would submit a bug report here if you think that something might not be right:
https://webdiplomacy.net/modforum.php

Re: Joined as a replacement, but info shows non-zero bet?

by echidna » Sat Mar 11, 2023 6:08 am

In the list of Notices I get on my home page, there is one for when I joined the game (pp-36) saying "You took over Turkey! Good luck"

Re: Joined as a replacement, but info shows non-zero bet?

by JECE » Sat Mar 11, 2023 2:22 am

Hmm, that's interesting. No gamemaster message notifying about any replacement either:
https://webdiplomacy.net/board.php?game ... e=Messages

Joined as a replacement, but info shows non-zero bet?

by echidna » Fri Mar 10, 2023 10:46 pm

I replaced the player of Turkey in game 542882, I think at zero cost, but the info shows for me, as Turkey, Bet: 5. Was I mistaken and it wasn't zero cost to join? Not a problem if that's the case, I'm just wondering if instead its a bug or a change in policy.

Top