I was in Egypt in 2012, after the first revolution of 2010, and during the second one which overthrew Morsi and the Islamic Brotherhood. In the week prior to that revolution/coup, everywhere I went there were signs of how much the tourism industry had collapsed. When I first arrived, our coach was given a guard of honour down the road by residents in every town we passed through, as we represented pretty much all of their income. The fall of Mubarrak destroyed their economy, and Morsi had failed to fix it, whilst trying to introduce measures to increase his own power. I then watched the tanks roll down the runway and the soldiers seize the airport on my final day there (I was in Luxor, thankfully, not Cairo, so didn't have too much concern). The Arab Spring destroyed Egypt twice, and poverty has shot up there.
And then you look to the neighbours. Sure, Morocco and Jordan passed a few liberalising laws, because the protesters were realistic there. Everywhere they tried to force regime change has taken some massive hits. Libya is now a failed state akin to Somalia, with zero signs of that changing. ISIS and Al-Qaeda control various towns and cities, alongside hundreds of different militias. Yemen is in the midst of a civil war that's been raging on for 6 years with zero international attention, as the Saudi's bomb the hell out of the Shia Houthi's that initially "won" that war, causing the Houthi's to ally with the very dictator who was initially driven out of power, against the Saudi-backed regime in Aden. Al Qaeda control half the country, which is the only thing that's topped ISIS joining the fun there too.
Syria, of course, has been utterly obliterated on every front with only the Kurds coming out of it having gained anything. All those initial protesters are dead. All the so-called "Moderate Opposition" that the West tried and failed to arm and support are dead. Assad is the Moderate at this point, given the opposition is now entirely consisting of Al Qaeda/Al Nusra, ISIS, or the Ottoman Revanchist Turk Nationalists backed by Erdogan in the North to contain the Kurds. The sooner we make our peace with the fact that Assad has won, the better. It's the only way the Syrian people will ever know peace again.
Iraq has been, once again, racked by war, undoing what little positive work NATO had managed to do toward the end of the Iraq War in building for the future, and throwing the Baghdad government completely into the sphere of Iran. ISIS may now have been defeated in Iraq, but the Saudi's will continue to meddle there now that Iraq is so firmly in Tehran's pocket. At the continued expense of the Iraqi people.
So, who does that leave? Lebanon, where Saudi Arabia has just attempted to restart their old civil war of the 80s and 90s by trying to force the Lebanon PM to step down (whilst in Saudi Arabia) and decry Hezbollah, possibly leading to another Israel-Hezbollah war. Unusually, that seems to have failed due to the restraint of Hezbollah themselves - rather ironic, and the Lebanese PM has now suspended his resignation and returned to the country.
Algeria and Bahrain, where the Arab Spring's protests were brutally suppressed and liberties curbed to below the level they were at prior to the whole thing. The UAE, Qatar, Kuwait, and Oman, where the entire thing was pretty much ignored. And Tunisia, the so-called jewel of success.
Sure, Tunisia now has a democratic government. It's only one of them refuse to cede power so far, with the standoff lasting a few months between the hardline Islamist faction and the secular moderates, but that deadlock was eventually broken and a new constitution agreed. Economically, though? Ever since ISIS slaughtered all those tourists at a beach resort a few years ago, Tunisia has joined Egypt (and since, Turkey) in the list of countries to have had their tourism industry implode in recent years, with Tunisia similarly reliant to Egypt on it. And as a result, poverty continues to rise and people continue to suffer. Because, as the Tunisian people have found out, democracy doesn't actually solve anything by itself. Whether it was a price worth paying remains to be seen in Tunisia (Egypt already decided it wasn't), but given the instability next door in Libya, it's going to be very hard for Tunisia to really do well going forwards.
So, yes, The Arab Spring was a failure. A failure caused by Western meddling for the past few decades, and leading to a dramatic rise of Islamism - something which had been somewhat receding after Al-Qaeda in Iraq (The predecessor to ISIS) was defeated in 2008. Something we'll all suffer for in the years to come. But really, you can trace the rise of Islamism as an ideology back to the failure of Pan-Arabism in the 1970s, after the Arabs picked the wrong side in the Cold War. The butchering of the Arab Spring has already killed off most liberal forces in the Arab World, and for the next few decades all we're going to see are strongmen vs Islamists, because people have seen what happens when you protest, and the results ain't pretty.